Add support for JULIA_REFERENCETESTS_UPDATE_AND_ERROR flag#137
Open
MasonProtter wants to merge 1 commit intomasterfrom
Open
Add support for JULIA_REFERENCETESTS_UPDATE_AND_ERROR flag#137MasonProtter wants to merge 1 commit intomasterfrom
JULIA_REFERENCETESTS_UPDATE_AND_ERROR flag#137MasonProtter wants to merge 1 commit intomasterfrom
Conversation
Member
|
This workflow is a very cool idea. But do we need this new option for your workflow? |
Member
Author
|
Ah, I didn't know about |
Member
|
we should document it better and make it clear how to use it to upload artefacts. |
Member
Author
|
Okay, so I'm having a lot of trouble still with |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds another possible env variable
JULIA_REFERENCETESTS_UPDATE_AND_ERRORthat acts likeJULIA_REFERENCETESTS_UPDATEexcept it will still emit an error when it updates the file.I want this for a CI workflow where I want to set this variable to true so that during the CI run, failed tests still show as failed tests, but then I can use a github action to collect all the changed files and automatically open a PR with the option to update the files.
There's a demo of the workflow here: MasonProtter/reference-test-test#1